Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup domain prefix #58

Merged
merged 5 commits into from
Sep 7, 2021
Merged

Fixup domain prefix #58

merged 5 commits into from
Sep 7, 2021

Conversation

rucarrol-goog
Copy link
Contributor

  • Use logging instead of print()
  • Use domain prefix from config instead of hard coded
  • Misc other fixes.

awlx
awlx reviewed Sep 7, 2021
View reviewed changes
wgkex/config/config.py Outdated Show resolved Hide resolved
awlx
awlx approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@awlx awlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff :). Merge as soon as you feel ready.

@awlx awlx merged commit c2b820a into main Sep 7, 2021
@awlx awlx deleted the fixup_domain_prefix branch September 7, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awlx awlx awlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rucarrol-goog @awlx